Offer a delegate EventListener in the okhttp plugin - #2206
Merged
Merged
Conversation
YYChen01988
force-pushed
the
PLAT-14334/okHttp-plugin-improvement
branch
from
June 30, 2025 15:58
13295b4 to
9c083fd
Compare
Collaborator
Android notifier sizes
Generated by 🚫 Danger |
lemnik
suggested changes
Jun 30, 2025
YYChen01988
force-pushed
the
PLAT-14334/okHttp-plugin-improvement
branch
4 times, most recently
from
July 1, 2025 08:33
e63e2ba to
f8271d7
Compare
YYChen01988
force-pushed
the
PLAT-14334/okHttp-plugin-improvement
branch
from
July 1, 2025 08:46
f8271d7 to
8a366ed
Compare
lemnik
reviewed
Jul 3, 2025
lemnik
changed the title
YYChen01988
force-pushed
the
PLAT-14334/okHttp-plugin-improvement
branch
from
July 3, 2025 07:57
8a366ed to
11183b1
Compare
lemnik
reviewed
Jul 3, 2025
YYChen01988
force-pushed
the
PLAT-14334/okHttp-plugin-improvement
branch
from
July 3, 2025 09:50
11183b1 to
2ae97e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Make it easy for more than a single okhttp
EventListenerto be used withbugsnag-plugin-android-okhttpChangeset
Added an optional delegate
EventListenerto theBugsnagOkHttpPluginso that more than a singleEventListenercan be registered.Testing
Introduced new unit test